Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename docs to _docs, tools to _tools #408

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Nov 20, 2024

The go toolchain ignores directories starting with _ and . as well as those named testdata. We rename the documentation rool to _docs so that it is not considered as part of the distribution package for the root module. The same treatment is applied to tools for good measure.

Fixes #406

The go toolchain ignores directories starting with `_` and `.` as well
as those named `testdata`. We rename the documentation rool to `_docs`
so that it is not considered as part of the distribution package for the
root module.
@RomainMuller RomainMuller requested a review from a team as a code owner November 20, 2024 13:58
@RomainMuller RomainMuller added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 4623562 Nov 20, 2024
25 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/rename-docs-folder branch November 20, 2024 16:56
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.25%. Comparing base (49288e7) to head (09c7f87).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   60.88%   60.25%   -0.63%     
==========================================
  Files         181      181              
  Lines       12707    12707              
==========================================
- Hits         7737     7657      -80     
- Misses       4439     4540     +101     
+ Partials      531      510      -21     
Components Coverage Δ
Generators 76.72% <100.00%> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 73.94% <ø> (ø)
Toolexec Driver 70.66% <ø> (ø)
Aspects 71.50% <ø> (ø)
Injector 71.87% <100.00%> (ø)
Job Server 62.03% <ø> (-6.10%) ⬇️
Integration Test Suite 54.24% <ø> (ø)
Other 60.25% <100.00%> (-0.63%) ⬇️
Files with missing lines Coverage Δ
internal/injector/builtin/generator/schema.go 68.62% <100.00%> (ø)

... and 4 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants